Submitted over 3 years agoA solution to the Four card feature section challenge
Four card feature section using HTML ,CSS
@comfort-deola

Solution retrospective
Just completed this challenge would need your honest review on how i could improve this
Code
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Yazdun
Hello Ajiboso and well done 👏 ! Here are my suggestions:
- On ACCESSIBILITY issue : each page should have at least one
main
tag which wraps the whole page's content and thismain
tag, must have alevel one heading
which tells what this page is about, thish1
can be hidden. your html containsmain
tag so just add ah1
to `main and your accessibility issues will be gone. Don't forget to generate new report though ! - for font family, it seems like you've forgot to add comma
font-family: 'Poppins'sans-serif;
, make sure to change it tofont-family: 'Poppins', sans-serif;
so your fonts load correctly. - I think box shadow is too thick, I would've used something along the long with
box-shadow: rgba(149, 157, 165, 0.2) 0px 8px 24px;
- Use
prettier
extenstion on your IDE to format your code.
✅ Also I opened a pull request to your github which take care of above issues
I hope this was helpful
Marked as helpful - On ACCESSIBILITY issue : each page should have at least one
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord