@VCarames
Posted
Hey @Targitay2012, some suggestions to improve you code:
- To give your HTML code structure, you want to set up your code in the following manner:
<body>
<header></header>
<main>
<section>
<div class="supervisor-card"></div>
<div class="team-card"></div>
<div class="karma-card"></div>
<div class="calculator-card"></div>
</section>
</main>
</body>
The Header Element represents introductory content.
The Main Element identifies the main content of the document.
The Section Element can be used to wrap content that is related to each other.
And since none of the cards make sense on their own, a simple Div will do for each card.
-
The heading is one single heading so the entire thing should be wrapped in a single <h1> Heading along with a Span Element.
-
Add a third layout to make the transition from mobile š± -> desktop š„ views smoother.
Happy Coding! š»š
Marked as helpful
@Targitay2012
Posted
@vcarames friend, thank you for taking the time to leave this review!
I'm new to web development, but it seems strange to me to set different classes for the same type of elements. Different elements (color, picture) can be done with nth-child()
Advice about heading <h1> and inside <span> is good!
I did not add an intermediate layout because it was not in the task, but in general, yes, you are right, without it the transition is quite sharp)
Best regards Purbo
