Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 12 months ago

Four card feature section

Daniel Tving•230
@dantvi
A solution to the Four card feature section challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Finishing the challenge and improving my CSS grid skills.

What challenges did you encounter, and how did you overcome them?

The main challenge I encountered were in the desktop version, when I needed to place the card elements according to the design. I have not been working that much with CSS grid, but after reading about it I managed to solve the problem.

What specific areas of your project would you like help with?

Any feedback would be appreciated.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Teodor Jenkler•4,040
    @TedJenkler
    Posted 12 months ago

    Hi @dantvi,

    Nice project! Here are a couple of suggestions for improvement:

    Responsive Design: I noticed that at around 975px, the p takes up the full width of the screen. Consider adjusting it to 50% or a similar value to make the content more compact and visually appealing.

    ARIA Labels: Adding ARIA labels to summarize the content of the cards would help screen readers better interpret your site. This will greatly improve accessibility.

    Otherwise, your site looks great and is responsive. Great work!

    Hope this helps!

    Best, Teodor

    Marked as helpful
  • David de Alencar•120
    @dealencardavid
    Posted 12 months ago

    Hey, Daniel!

    Great job here and nice job handling the positioning with a combination of id's and a single grid.

    The only thing I would say that could be improved in your solution is to change the card background-color to pure white to better match the design.

    Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub