Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Four card section

Bazz 165

@Basit-Dev

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
Grace 27,950

@grace-snow

Posted

Hi Bazz,

Looks nice. There's a few things I notice when looking at your code though:

  • you've made your base font size 10px (62.5%) but the style guide said 15px. 10 is really really small for a base.

  • You haven't taken advantage of css grid fully by placing your center column cards in their own container. That makes their parent the grid child instead of the cards themselves. CSS Grid is specifically designed for 2 dimensional layouts like this, so I'd strongly encourage you to look into grid rows and how to place all cards as direct grid children.

Once you master css grid fully you'll feel like you've got layout super powers! 😉

Good luck

0

Bazz 165

@Basit-Dev

Posted

@grace-snow The center columns cards will be interesting as I did struggle on that. Thanks for the feedback! 🙂

0
P
ApplePieGiraffe 30,565

@ApplePieGiraffe

Posted

Hey, Bazz! 👋

Good work on this challenge! 👍

I noticed you added a cool little animation upon hover of the feature cards! 😉

I suggest,

  • Setting a max-width on the feature cards so that they do not grow too wide when the layout first changes from desktop to mobile.
  • Setting overflow-x: hidden on the body (or something similar) to prevent the horizontal scroll bar from appearing in the desktop layout.
  • For some reason, the heading of the page gets cut off when the height of the screen decreases, meaning it can't all be seen on some smaller desktop screens. You might like to look into that!

Keep coding (and happy coding, too)! 😁

0

Bazz 165

@Basit-Dev

Posted

@ApplePieGiraffe Thanks for feedback!🙂

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord