four-card-feature-section

Community feedback

• 

  

  Grace•32,130

  @grace-snow

  Posted over 4 years ago

  Hi

  Well done on completing the challenge. I have some suggestions for and some questions about your approach if that's OK...

  • first, it's a shame you've not used css grid for this. The challenge is a 2 dimensional layout that's perfect for grid. Flexbox is suited to 1 dimensional layouts
  • on mobile portrait all the cards are off center for me. This is because you're using percentage widths and a min-width on the card. That min-width is wider than 90% on my phone. Width 100% and only a max width on the card would be better.
  • following on from that, you may find you have more control over styles of you use padding on blocks/elements wrapping other items instead of percentage widths, which can vary greatly depending on context.
  • its best to use Em or another relative unit for letter spacing or text will become unreadable when zoomed
  • why are you positioning the card wrapper absolutely?
  • why is there an important in the css?
  • in html you've jumped a heading level. Your h4s should be h3s.

  Overall the rest of the solution looks close to the design. I hope these ideas help you for this or future challenges

  12
• 

  KAKANAKOU Miguel Stephane•100

  @MiguelSteph

  Posted over 4 years ago

  Hi @Grace-snow

  Thank you again for your useful suggestions. I have apply them in this commit https://github.com/MiguelSteph/four-card-feature-section/commit/5dd0f8860e0ddd7d5535499707f8e1e81dd258e8

  00