@denielden
Posted
Hey Faizan, congratulations on completing the challenge! You did a great job 😉
Let me give you some little tips for optimizing your code:
- add
main
tag and wrap the card for improve the Accessibility - remove
min-height
frommain
class and setwidth: 20rem
- remove
min-height and width
frommain-one
class because they are unnecessary - remove all
margin
frommain
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Hope this help! Happy coding 😁
Marked as helpful