Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 month ago

Frontend Mentor - Social Links Profile

pure-css
AJ-Tan•190
@AJ-Tan
A solution to the Social links profile challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?
  1. Improving my naming conventions for my HTML Classes using BEM

  2. Organized in writing my css properties by doing it in alphabetical order, I'm open for suggestion on how I can improve on this part.

What challenges did you encounter, and how did you overcome them?

The challenge I encountered is naming my HTML element classes. This may sound something trivial, but I want to have a standard or guidelines on how I name my classes. By using the BEM (Block Element Modifier) as my basis for my class names, I finally have a standard on how I name my HTML elements.

What specific areas of your project would you like help with?

I wish to improve in how to organize my CSS file. How to sort my css properties and etc.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Mustafa Sen•3,180
    @mustafasen97
    Posted about 1 month ago

    Your design is pretty good. Your code structure looks good too. However, I'd like to give you a few tips on CSS.

    Use a consistent order for CSS properties

    A common and popular convention is:

    1. Positioning (position, top, right, bottom, left, z-index)
    2. Display & Flex/Grid (display, flex properties, grid properties)
    3. Box Model (width, height, padding, margin, border, box-sizing)
    4. Typography (font-size, font-weight, color, text-align, line-height)
    5. Background & Decoration (background, border-radius, box-shadow, etc.)
    6. Other (cursor, transition, animation, etc.)

    Example (reordered):

    .profile-card {
      container-type: inline-size;
      display: grid;
      justify-self: center;
      gap: var(--spacing-md);
      
      width: clamp(15rem, 100%, 19rem);
      padding: var(--spacing-lg);
      border-radius: 1rem;
      
      background-color: var(--grey-800);
    }
    

    Group similar parts together

    Separate your base / reset, variables, layout, components, and utilities:

    /**** Base styles ****/
    * { ... }
    html, body { ... }
    body, a { ... }
    
    /**** Variables ****/
    :root { ... }
    
    /**** Layout ****/
    main { ... }
    
    /**** Components ****/
    .profile-card { ... }
    .profile-card__header { ... }
    .profile-card__image { ... }
    .profile-card__user-details { ... }
    .profile-card__social-media { ... }
    
    /**** Utilities or helpers ****/
    /* if you have */
    

    Add comments

    Clear section comments help quickly scan large CSS files.

    /**** PROFILE CARD HEADER ****/
    .profile-card__header { ... }
    
    /**** SOCIAL MEDIA LIST ****/
    .social-media__list { ... }
    

    Keep nesting shallow

    Nesting too deep (like .profile-card .profile-card__header .profile-card__user-details) can make CSS harder to maintain. One or two levels is usually enough.

    Use shorthand where practical

    For example:

    padding: var(--spacing-lg); /* instead of padding-block, padding-inline separately */
    border-radius: 0.5rem;      /* instead of writing all corners separately */
    

    In summary:

    • Pick and stick to a property order (position → layout → box → typography → visuals → other)

    • Group by component

    • Use comments for sections

    • Keep selectors flat & short

    • Use tools to auto-format

    I hope these help you. Keep designing and improving yourself. Good luck with your future designs.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub