Frontend Mentor | 3-column preview card component

Community feedback

• 

  Lucas 👾•104,160

  @correlucas

  Posted almost 3 years ago

  👾Hello @maxted83, congratulations for your new solution!

  👏 Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

  1.Your solution seems fine, you did a really good work wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  2.About the semantics, you can replace all blocks that you've used <div> and replace with <article> thats a better html markup for this situation.

  3.Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.

  ✌️ I hope this helps you and happy coding!

  10

  Marked as helpful
• 

  Willy Fajar Ramadhan•360

  @wllyvx

  Posted almost 3 years ago

  Hi! Nice Job! I think it's because your font sizes are too large, I opened a pull request to your repo which fixes some issues, please have a look! :)

  10

  Marked as helpful