Frontend Mentor | Product preview card component

Community feedback

• 

  Saulius K.•560

  @TH3RIV

  Posted over 2 years ago

  Hi, @ByProxy66! To me it looks pretty good.

  The main issue I have with your project is that it does not contain landmarks (header, main, footer). Pretty sure a page content has to be wrapped in <main></main> landmark for it to recognise what is the main content of the page.

  Therefore I would suggest doing the following:

  • Wrap your card within main landmarks.
  • Wrap your attribution within footer landmarks.

  Hope this helps!

  22

  Marked as helpful
• 

  VincenzoMuolo•180

  @VincenzoMuolo

  Posted over 2 years ago

  Hi there!

  The layout works great! The only thing i would suggest you is to shrink a bit the card on mobile layout, maybe by adding some padding / margin on left and right side.

  Hope this give you some help!

  Cheers

  11

  Marked as helpful