Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Frontend Mentor | Profile Card Component

@aaronpaulgz

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback is welcome 💚

Community feedback

T
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hey, Aaron Gonzalez! 👋

Good job on this challenge! 👏

I suggest,

  • Using a single <h1> tag for the text "Victor Crest 26" rather than an <h1> and an <h2> tag since those two elements really aren't two separate headings. You can use the <span> tag to easily style the "26" differently than the rest of the text.
  • Another way of positioning the image that I might share would be to put in the div.card-identifier and use negative margin to slide it up into the background of the card. That way, you can group the image with the rest of the profile information and not have to use so much padding in the div.card-identifier to push the rest of the content down. 😉

Keep coding (and happy coding, too)! 😁

2

@aaronpaulgz

Posted

@ApplePieGiraffe Thanks, Very cool feedback 😄 I'll implement it as well

Virtual hugs!

0

@aaronpaulgz

Posted

@ApplePieGiraffe Feedback implemented :D Thanks

1
Arturo Simon 1,785

@artimys

Posted

Nice work on the challenge. The card looks well designed. Really good practice of using CSS custom properties to organize your colors, and fonts.

I know those background images can be tricky. Your approach with the .ornaments container is totally fine. I'll leave here another method that might prove useful. Checkout multiple background images. more info here

and just in case there's a shorthand for the overflow property

// from this
overflow-x: hidden;
overflow-y: hidden;

// to this
overflow: hidden

Keep on coding!! 👍

2

@aaronpaulgz

Posted

@artimys Thanks for the feedback man. I just implemented :D

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord