Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Frontend Mentor - QR code component solution

TPpseudo 60

@TPpseudo

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Overall feedback would be greatly appreciated.

Specific question:

  • Is there an alternative way of pushing down the <footer class=".attribution">? Using margin pushed my other content upwards.

Community feedback

@MelvinAguilar

Posted

Hello there 👋. Good job on completing the challenge !

I have one suggestion about your code that might interest you.

  • The issue with position fixed for the footer is that the text often overlaps the component on mobile devices. You have two options: 1) use a media query to solely remove the fixed position on mobile devices or, 2) since you are using flexbox, use margin: auto to relocate the footer to the bottom. e.g.:

    .product__card {
        margin: auto;
        . . .
    }
    
    .attribution {
        /* position: fixed; */
        /* bottom: 0.3rem; */
       text-align: center;
    }
    

    More info here

    But even so you will have the component a bit higher, that is inevitable without using position fixed or absolute. :(

Happy coding!

1

TPpseudo 60

@TPpseudo

Posted

@MelvinAguilar

That's great. Thank you for the feedback!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord