Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 4 years ago

Frontend Mentor - Stats preview card component solution

Naresh•90
@nareshpoonia
A solution to the Stats preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I would love to get some feedback here.

This is my first project, Though I managed to match the design, I must have made a lot of mistakes, must have done things that aren't standard practice.

If you can point those out, It would help me improve.

Thanks a lot.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Agata Liberska•4,075
    @AgataLiberska
    Posted about 4 years ago

    Hi Naresh! Well done on this solution, it looks good! Here's a few things I noticed that could help you:

    • I think it would be a good idea to set a max width to your card in desktop layout - on my screen it stretches just a bit too wide, you lose a bit of the image as well. It may also be good to move your breakpoint a bit - at 1024px there really isn't enough space for the card to be horizontal yet, and some tablets are quite a bit smaller than that. (you can view what the design look on different viewports in the browser)

    • In mobile layout, the class .container-1 has grid columns and rows but not display: grid - so they're not really doing anything :)

    • Also in mobile layout, it would be good to add just a bit of padding-top of card-text div.

    • Instead of using margin to position the card on the screen in desktop design, you can set body's min-height to 100vh and use grid or flexbox to center the element within it :)

    • There is a CSS property background-blend-mode you could've also used to blend the image with a background-color instead of adding an overlay (although that's not a bad option either)

    • Make sure that the link to your site in the attribution is correct.

    Overall though the result looks really good, I just thought I'd mention some things that could make things a bit easier for you in your next challenges :) happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub