Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Frontend | Perfume Product

@ammarqureshi120

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my another challenge. Please give your feedback so that I can improve more.

Community feedback

@madkn1311

Posted

Hello Ammar,

You designed the card really well. :)

To center your card you should do the following:

min-height is the best option as it will change when needed(i.e enable responsiveness). Plain height property won't allow responsiveness.

body{
min-height: 100vh;
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
}

Marked as helpful

0

@ammarqureshi120

Posted

@madkn1311 Thankyou! I will improve this.

0

@madkn1311

Posted

@ammarqureshi120 you're welcome..!!

0
AlwinJun 230

@AlwinJun

Posted

Mr.Ammar you can put your main content inside of main tag for better accessibility or put a role attribute with a value of main in your card-container element <div class="card-container" role="main">. By the way nice job.

Marked as helpful

0

@ammarqureshi120

Posted

@AlwinJun Thankyou! For Your Feedback.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord