Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

FrontEnd Practice

bootstrap
HIMANSHU•10
@HIMU-2001
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I wasn't able to add border radius to the top part of the qr code(don't know the reason). While viewing the website in various sizes as because the card's position was changed to relative it comes out of the container.

Would be great if someone could check out the code and help.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Yusuf Babatunde•310
    @owocoded
    Posted almost 3 years ago

    Why not try to give your img class in your html and do the same in your css. Something like this; .img{ border-radius: 10px; } I hope this is helpful. Happy coding.

  • P
    Jake Godsall•1,390
    @jakegodsall
    Posted almost 3 years ago

    Hi, some of the styling from bootstrap is overriding the style on the img tag for the top-left and top-right border radius.

    I've not used bootstrap yet but inspecting your component using the Chrome dev tools it seems that

    .card-img, .card-img-top {
        /border-top-left-radius: calc(0.25rem - 1px); 
        border-top-right-radius: calc(0.25rem - 1px);
    }
    

    from

    bootstrap@5.0.2/scss/mixins/_border-radius.scss

    is causing the troubles.

    Hopefully someone with a bit more knowledge can provide more insight on this.

  • PhoenixDev22•16,830
    @PhoenixDev22
    Posted almost 3 years ago

    Hi HIMANSHU,

    Congratulation on completing this frontend mentor challenge. Excellent work! I have some suggestions regarding your solution:

    • You should use <main> landmark to wrap the card . HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
    • Page should contain <h1>. In this challenge , as it’s supposed to be a part of a whole page, you may use<h1>with sr-only class hidden visually and present for assistive tech users. Then you can use <h2> instead of <h5>
    • In my opinion, the image is an important content. The alternate text should indicate where the Qr code navigate the user: like QR code to frontend mentor not describes the image.
    • In order to center the card on the middle of the page , you can use the flexbox properties and min-height: 100vh for the <body> add a little padding to the body that way it stops the card from hitting the edges of the browser without any need for position: absolute or relative of the container and the card.
    • Consider using rem and em units as they are flexible, specially for font size better to use rem. If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs.Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
    • Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.

    Overall, your solution is good. Hopefully this feedback helps.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub