@0xabdulkhalid
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
.
- We don't need to use
margin
to center the component both horizontally & vertically.
- You already using
Flexbox
for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.
body {
justify-content-center;
align-items: center;
}
- Now remove these styles, after removing you can able to see the changes
.card {
margin: auto;
}
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
@tonyiboy
Posted
@0xabdulkhalid thank you for your reply! I know that I could use justify-content and align items because I use flex on body and my card became flex items.I wanted to achieve same thing with 1 line of the code and not 2 lines.If you have any comment why would that margin center be bad please feel free to tell me I like to learn new things and new tricks.Thank you