Fully Responsive Landing Page | React | Webpack | Sass | Contexts

Community feedback

• 

  Jonh Alexis•555

  @LaplaceXD

  Posted almost 5 years ago

  Hello Sapinder, good job on this challenge, although some minor adjustments (like spacing) could do some work. Your solution looks stunning and well made.

  For some suggestions in the code, I can only comment on the Sass part, since I have yet to lean ReactJS. I see that you've been using the nesting feature of sass, while generally a great feature as people have proclaimed it to be, you should try to stick to at least 3 levels deep of nesting, any more than that, and it's basically nest abuse (as others call it 🤣). And another thing to note would be to avoid nesting classes, or elements together, as it would generate a higher specificity, and the project would be harder to maintain as it grows bigger. You could use a methodology like BEM, and the 7:1 pattern (since it focuses on components like React) to minimize nesting and generally make your work more scalable.

  These are all the suggestions I could make. Anyways, good job on the challenge, you owned it pretty well, cheers!

  10
• 

  Sapinder•565

  @sapinder-pal

  Posted almost 5 years ago

  I appreciate your feedback. I'm thinking to improve upon my usage of sass, however, in this project I spent a great amount of my time in implementing a lot of webpack stuff like- mini-css-extract-plugin, postcss-loader, autoprefixer, etc., and understanding how everything works. I'm slowly improving my way of working and forgetting my bad practices. I'll try to improve my sass way of working. Could you please elaborate the 'BEM' and '7:1' you said about?

  02