@Diarrah
Posted
Pretty nice work.
A couple constructive criticisms would be:
· Every image needs an alt tag - even if it's set to an empty string (ex. alt="") - that will get rid of almost all your HTML + accessibility errors.
· You can set the font-family on the html tag itself so that you don't have to keep defining it on every element (ex: html { font-family: 'Inter', sans-serif }
· Cursor: pointer on the dark-mode label clicker so the call-to-action for the user is more clear
· Using a root selector to change the colors from dark to light. You can look at my solution to this project to see what I mean by that
· I would make it responsive a bit earlier, maybe by 100px
Great job on your second project 🎉
@MilitusInnocent
Posted
@Diarrah Thank you so much. I just noticed the alt thing. Lol. I really appreciate.. I'm going to check on yours right away.
Is there like a platform where people can share ideas aside the slack?
@Diarrah
Posted
@MilitusInnocent Hmmm I'm not sure. I think I've heard of a site called Dribble but I don't know if you can follow people on there.
@MilitusInnocent
Posted
@Diarrah okay. What's your email? If you don't mind.
