Skip to content
  • Learning paths
  • Challenges
  • Solutions
  • Articles
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

function created with JQuery

jquery
Lubomir•30
@vlubosh
A solution to the FAQ accordion card challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ken•935
    @kenreibman
    Posted about 3 years ago

    Great job! I like your use of jQuery on the accordion.

    Initially your design looks great, but your entire card starts to fall apart when the viewport width starts to get smaller. I have a few suggestions...

    • I believe you are having these issues because you are giving your containers a fixed width and height. Giving fixed dimensions like that lead to lots of responsiveness issues. Instead I would start using max-width, and use rem units instead of vh and vw for setting container dimensions.
    • I also highly advise you against declaring a set height, and let your content expand on its own. Very rarely do I set a specific height for certain containers in my projects. This relates back to your parent element, which is your body tag in this case. I would set a min-height: 100vh to make it more responsive.
    • You might also want to look at your media query breakpoints again, as there is a gap between your desktop to mobile layout where it completely breaks the entire website.

    I actually recommend you to take a look at a video of someone completing this challenge on Youtube, or look at my code for the same problem

    I hope this helps and keep learning!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub