Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Fylo dark theme landing page master

Syl 730

@sylcym

Desktop design screenshot for the Fylo dark theme landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi! I just completed this challenge, any feedback is welcome! Thanks :)

Community feedback

Tryt4n 940

@Tryt4n

Posted

In your section-info class would be better to use grid instead of divided it into two div and use flexbox on them. You just could do something like this:

display: grid

grid-template-columns: 1fr 1fr;

grid-template-rows: 1f 1ft;

And then it would be easier in mobile view:

grid-template-columns: 1fr;

grid-template-rows: repeat(4, 1fr);

Also you could add some transition while :hover elements. Now it's just so instant especially in your button. Give transition: 300ms ease-in-out and would bo smooth.

About accessibility you done good job with creating a label although it has no content, but in that case you should give it aria-label: "Enter email"

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord