@ksenius
Posted
Hi! Good job!
I really liked the hover effects! 👍
The better solution for adding the curve image to the intro section is adding it as a background image via CSS. Thus, you'll be able to position it at the bottom of the section with the background-position
property and no additional elements with position: absolute
needed.
Here is a link to the CSS Backgrounds reference on w3schools.
As for component approach, I noticed that you used BEM naming. If that is so, I'd like to mention that some of your classes names are incorrect. Here is a couple of examples:
-
.testimonial_card
should be.testimonial-card
, because_
is used for modifiers; -
You have
.profile__avatar
and.profile__image__avatar
. In BEM there can't be an element of an element, but you can nest elements. So, it would be better to name the latter one something like.profile__avatar-image
.
@zuolizhu
Posted
@ksenius Thank you for you suggestion! I just figured out using linear-gradient with background image can do you job haha :D.