Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Fylo Dark Theme Landing Page Using CSS Grid (Commented Code)

@aashish-cloud

Desktop design screenshot for the Fylo dark theme landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison

SolutionDesign

Reports

Accessibility report (2)
error

This textinput element does not have a name available to an accessibility API. Valid names are: label element, title undefined, aria-label undefined, aria-labelledby undefined.

<input type="text" placeholder="[email protected]" name="" value="">
error

This form field should be labelled in some way. Use the label element (either with a `for` attribute or wrapped around the form field), or `title`, `aria-label` or `aria-labelledby` attributes as appropriate.

<input type="text" placeholder="[email protected]" name="" value="">

aashish-cloud’s questions for the community

Any suggestions on how I can improve are welcome. Thanks! :)

Community feedback

P
Jen 1,230

@En-Jen

Posted

Your solution looks great! Really clean look on all screen sizes. I really like the look of the lighter grey part behind the quote boxes. Your code looks nice and organized too, easy to follow. Just a couple suggestions. Try to make the font look different for the for the name of the person who said the quote and the position they hold in the company. In the design the name is in bold and both the name and the position have smaller font size than the text for the quote. Also, try to use relative units (rem, em) for things like font-size, margin, padding, etc. It will make it easier to make your pages responsive. Keep up the great work! -Jen

1


@aashish-cloud

Posted

@En-Jen Thank you for reviewing my code Jen! I will surely work on your suggestions and use relative units from now on. Again, Thanks for taking the time to drop me a kind note. - Aashish

0

Please log in to post a comment

Log in with GitHub
Slack logo

Join our Slack community

Join over 180,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!