Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Fylo dark theme landing page using FlexBox

@lukassiarny

Desktop design screenshot for the Fylo dark theme landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, I'd like to get a feedback on this one, please. I'm quite new to frontend. I'm not sure about the structure of my html. Isn't there too much markup, too much divs etc..? Any recommendations to help improve my workflow are welcome. Thanks.

Community feedback

@lukassiarny

Posted

Thank you for the feedback, I really appreciate it. I'll try to look at it when I have more time, but now I'm "fighting" with another challenge. :)

0
P
Matt Studdert 13,611

@mattstuddert

Posted

Firstly, great work on this challenge! You've done a really good job at working to the design 🙌

With regard to your question about your HTML structure, overall you've got a really good structure. There are a few areas where you could remove some div elements (.contact-item-1st-row being one example), but that's not the end of the world. You're using semantic HTML5 structural elements correctly, which is the main thing.

Keep up the great work! 👍

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord