Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Fylo dark theme landing page with html and css only

Ugorji Miracle• 65

@amarealcoder

Desktop design screenshot for the Fylo dark theme landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback on my styles are welcome

Community feedback

Favourite Jome• 1,110

@jomefavourite

Posted

Great job, I like the work and here are my feedbacks

  • Making use of the % unit to determine the overall width, using margin and padding of each section, without including max-width property will make the layout to keep growing on large screens.

  • Adding a max-width property to the texts on the page will be very helpful, so as to stop the texts from growing at a certain point.

  • The model with the selector .access, I noticed it isn't always centered so I made some changes.

.access {
    padding: 5% 5%;
    box-shadow: 3px 3px hsl(0deg 0% 5%);
    height: auto;
    width: 80%;
    max-width: 700px;
    /* margin: -10% 21%; */
    background-color: hsl(217, 28%, 15%);
    position: absolute;
    margin-top: -110px;
    left: 50%;
    transform: translateX(-50%);
}

Also on the media query

@media (min-width: 320px) and (max-width: 500px)
.access {
    /* margin: -2% 5%; */
    padding: 1.5rem;
    width: 90%;
}

Lastly, I'll like to talk about the percentage unit you used frequently on margin and padding, it might cause issues as the viewport increases so I'll advise you make use of other responsive units like em, rem.

Then on the width of each sections, you can use percentages. Well, it varies and depends on the use case.

Here's an article I wrote that might be helpful.

Also, I'll strongly advise you take this course Conquering Responsive Layouts by Kevin Powell.

1

Ugorji Miracle• 65

@amarealcoder

Posted

@jomefavourite Thank you very much for your sincere and wholistic feedback. I struggled with making the sections keep their respective layout. I never knew what the real problem was. But now I know, thanks to you.

1
Favourite Jome• 1,110

@jomefavourite

Posted

You're welcome@EagleNerd

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord