Hello, Diu Gach! 👋
Good job on this one! 🎉 Your solution responds well and overall looks good. Here's my suggestions:
- Add
:focuspseudo class to interactive elements like anchors, buttons etc. Useoutlineproperty to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default:focuspseudo class withoutlineproperty. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles. - Change the
altattributes for the.header__logo,.intro__img,.features__icon, as they don't add any extra context for screen reader users. Since your images are decorative youralttext should be provided empty (alt="") so that they can be ignored by assistive technologies. - Read about Sass 7-1 pattern to keep your file management orginazed.
Good luck with that, have fun coding! 💪
Marked as helpful
1
Diu Gach• 145
@DiuGach
Posted
@tediko I appreciate your helpful feedback buddy, thanks so much, I will make sure to implement those great ideas you helped me with, and about the 7-1 rule, I didn't do it because I see the project is somehow not huge or is it a recommended practice to always use 7-1 pattern?, anyway you have helped me alot, happy coding too 😊.
0
@DiuGach No, it is totally fine to keep it simple with projects like this :)
0
