
Submitted over 4 years ago
Fylo data storage component using HTML5 and CSS3
@roshanvkhatri
Design comparison
SolutionDesign
Solution retrospective
Suggestions welcomed for improvement.☺
Community feedback
- @alex-kim-devPosted over 4 years ago
Great solution, Roshan! Pretty close to the design and responsive. There's a couple of points worth mentioning:
- I don't think putting the whole component out of flow using absolute positioning is a good practice. The way to go would be to give the body
100vh
height and position the component inside using flexbox. - the icon buttons aren't accessible to assistive technology users. Consider using
<button>
elements instead of divs + add styling for states (:active
,:focus
,:hover
).
Congratulations on solving your first challenge and good luck with the next one!
1 - I don't think putting the whole component out of flow using absolute positioning is a good practice. The way to go would be to give the body
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord