Skip to content
Submitted about 4 years ago

Fylo Landing Dark - SCSS and JS

P
Dave•5,295
@dwhenson
A solution to the Fylo dark theme landing page challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

This is my second challenge trying out SCSS. I enjoyed SCSS much more this time around as I am getting more comfortable with it.

Any comments on how I can improve my use of SCSS would be particularly appreciated. Any other comments or feedback on any points are also very welcome.

PS. I bumped up the font size compared to the design specification as I found it to be very small in the design....

Code

Please log in to post a comment

Log in

Community feedback

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe

    Hello, Dave! 👋

    Nice job on another challenge! 😀

    I suggest decreasing the space between the top of the page and the header (since there seems to be quite a bit of margin-top on the header, especially on smaller screens). One other detail that I think would be a nice touch is to allow the background of the footer to extend to both sides of the screen so that there isn't any empty to the sides of the part of the design on larger screens. 😉

    Those are just small things, though. Overall, your solution looks pretty great and responds nicely! 👍

    Keep coding (and happy coding, too)! 😁

  • P
    Dave•5,295
    @dwhenson

    Oh please ignore that extra-wide button in the screenshot - it's due to me using the fit-content value which isn't recognised in Firefox and maybe some other browsers.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord