Hello, Dinesh! π
Congratulations on finishing another challenge! Again, good job! I see that you followed my last suggestions, great! What I can hint you this time is:
- Since you wrap your logo into anchor change your alternative (
alt
) text to be more descriptive. Change it to something like - 'Fylo - homepage'. - Your
hero__img
andproductive__image
images are decorative so youralt
text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers. - Instead of putting image of quotes in
.testimonial
HTML what you can do is to use pseudo element::before
on your.testimonial
element. Set it toposition: relative
and your pseudo element asposition: absolute
. Put your image usingcontent: url('image.jpg')
.
Good luck with that, have fun coding! πͺ
1
Dineshβ’ 1,115
@Dinesh1042
Posted
@tediko Thank you for your feedback! π
- I will make sure to use
alt
tag more descriptive. - If I ignored
hero__img
andproductive__image
imagesalt
tag frontendmentor validation is gonna yell at me. So I have used alt in images tag but in real world scenario I will make sure to ignore these alt in the decorative images. - Putting quote image in the pseudo element
::before
is an awesome idea. I will change it to that.
Thanks, Happy Coding.π
0