@PhoenixDev22
Posted
Hello Tammy,
Congratulation on completing another frontend mentor challenge.
Excellent work! I see you have received some incredible feedback. I have some more suggestions if you don't mind:
HTML
- Images must have alt attribute. The logo's alternate text is needed on this image . You can use the website's name as an alternate text. You may set
alt=”Fylo"
. If you are going to leave the logo not wrapped by<a>
, it’s better to place it out the<nav>
as it does not navigate the user in anywhere(only an image)
- In
class="navbar">
, Put your links within an unordered list structure so that a screen reader will read out how many things are in the list to give visually impaired users the most information possible about the contents of the navigation.
- Wrap your sections within
<main>
landmark.
- look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content. For decorative images, you set an empty
alt
to it with anaria-hidden=”true”
to remove that element from the accessibility tree. This can improve the experience for assistive technology users by hiding purely decorative images.
- Forms with proper inputs and labels are much easier for people to use. To pair the label and input, one way is an explicit label’s
for
attribute value must match its input’sid
value. Input fields without accompanying labels can lead to accessibility issues for those who rely on screen readers. If a screen reader comes across an input field without a label it will try to find some accompanying text to use as the label. (To hide the label visually but present for assistive technology, you may usesr-only
class )
- For the alternate text of the avatar testimonial should not be ** avatar-testimonial** . You can use the avatar’s name
alt=" kyle burton"
. Also consider that the alternate text should not be hyphenated , it should be human readable
- For the testimonial , you may use
<blockquote>, <figure>, <figcaption>
-
Use the
<nav >
landmark to wrap the footer navigation witharia-label=”secondary “
oraria-label=”footer”
. A brief description of the purpose of the navigation, omitting the term "navigation", as the screen reader will read both the role and the contents of the label. Thenav
element in the header could use anaria-label="primary"
oraria-label=”main”
attribute on it. The reason for this is that, you should add thearia-label
for a nav element if you are using the nav more than once on the page.you can read more in MDN -
You may use the
<address>
tag to wrap the contact informationclass="sets1"
for the author/owner of a document or an article (email and phone number.)
- If your icons are purely decorative, you'll need to manually add an aria-hidden attribute to each of your icons.
- The social links wrapping the icons must have
aria-label
orsr-only
text indicate where the link will take the user. . Then you setaria-hidden =”true”
to the icons to be ignored by assistive technology . It might look like this:
<ul class=”....” >
<li><a href=”#” aria-label="Visit our facebook"> <i class="fa-brands fa-facebook " aria-hidden=”true”></i></a></li>
<li><a href=”#” aria-label="Visit our twitter"> <i class="fa-brands fa-square-twitter" aria-hidden=”true”></i></a></li>
<li><a href=”#” aria-label="Visit our instagram"> > <i class="fa-brands fa-square-instagram" aria-hidden=”true”></i></a></li>
</li>
</ul>
Aside these , you did great work. Hopefully this feedback helps.