Github search app with HTML, CSS and JS

Community feedback

• 

  Elaine•11,360

  @elaineleung

  Posted almost 3 years ago

  Hi Oba, this looks really cool, and it's nice to be able to search for my GitHub profile 😂

  Anyway, my comments are more about the CSS here: I noticed the component wasn't centered, and so I tried centering it in the inspector using display: grid and place-content: center, which went OK in the end after removing some padding top also. I then looked at your stylesheet and saw that you had font-size: 62.5% on your html selector, which was a bit puzzling to me, but it explains partly why even when using an 1.3rem fontsize, it doesn't look particularly big (that is, until I removed that line in the HTML and things look more or less the way they should). I would suggest not putting the font-size on the HTML unless you really need to, as that would change all the proportions for everything. Whenever possible, it's best to have it on the body selector, and also it's best to use rem units for font size; if you need it on HTML, do use rem to be safe (the default is 1rem usually).

  Hope this helps a bit, and great work!

  25

  Marked as helpful