GitHub User Search

Community feedback

• 

  Vanza Setia•27,715

  @vanzasetia

  Posted almost 3 years ago

  Hi, AceDub! 👋

  Congratulations on completing this challenge! 🎉 Your solution looks pretty good! 😀 I like the idea of having a loading spinner! 👍

  Here are some suggestions for improvements.

  • I recommend adding rel="noopener" to any anchor tags that have target="_blank". This is a security essential for external links. I suggest reading the web.dev article to learn more about this.
  • I would not recommend setting any height to the html element. I suggest treating the body element as the webpage of the site.
  • I would also suggest not setting any height to the body element. If you ever need to set a height then use min-height instead. This way, the body element is allowed to grow if ever needed.
  • Having the desktop layout at 1440px is too late. So, I suggest adjusting the breakpoint of the media query. As a side note, the design sizes are telling you that the site should look like this at this specific screen size. They have nothing to do with the media queries.
  • The statistic should be a list with three bullet points. Also, the statistic categories and the statistic numbers should not be headings. Use span instead (since it will be wrapped by li). Heading tags have meaning and are used to give structure to the page. You can think of headings like titles in documents. So, I recommend writing the HTML without any styling so that you can make a better decision on what HTML element you should use for the web content.

  Overall, great work. The site even still looks good at 320px which I would consider the smallest screen size.

  I hope this helps! Keep up the good work! 👍

  01
• 

  mubizzy•1,520

  @mubizzy

  Posted about 3 years ago

  Excellent job on this challenge! your report has a few issues though:

  1. wrap everything in your body in <main> or use semantics

  2.   it is a best practice to use both HTML 5 and ARIA landmarks to ensure all     content is contained within a navigational region.

  Hope it helps:)...don't forget to mark it as helpful 👍

  You can get more details here...click here

  02