Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Github user search app (Html,Css(Sass),Js,API)

accessibility, cube-css, sass/scss
Pablo Dettori•740
@p4bloxx
A solution to the GitHub user search app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi everyone;) With this challenge I continued my training regarding the use of APIs and the management of incoming data. Overall I didn't have any major problems, it was a good workout.

If you want to tell me your opinion about the solution, and if you think there is something to improve or you want to give me some advice or feedback, I'm here ;)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Matt West•440
    @matt-o-west
    Posted over 1 year ago

    Hello! Thank you for your submission! I have some feedback for you:

    • In your input, you've added an onclick event listener. While this is fine, it can improve the user experience (and is best practice) if you code this as form with an onsubmit. When the form is submitted, you perform the same callback function.
    • Your theme is toggling correctly, but the UI isn't updating the string label for the theme button (i.e. it always says 'Light' regardless of the current state). It should be a simple fix, adding into your toggle function to update the text inside that node when the theme toggles.
    • Responsiveness is looking good, although your placeholder text is crashing with error messages in mobile when they appear. You might need to put the error message above or below the input on mobile.

    Above all, the solution you submitted is great and you should be proud! Great work! 🎉

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub