Skip to content
Submitted over 3 years ago

GitHub user search app using Flexbox and CSS Grid

axios
Nakoya Wilson•1,530
@nakoyawilson
A solution to the GitHub user search app challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Originally I used prefers-color-scheme media queries to set the initial colour theme but with this method my javascript for the theme toggle button worked on Chrome but not Firefox so I ended up changing my approach to setting the initial colour theme.

I also struggled with what to do/where to place the error message on smaller screen sizes.

Any suggestions on how I can improve are welcome!

Code

Please log in to post a comment

Log in

Community feedback

  • Billy Hick•330
    @TheArkhamKnight781526

    Overall, this is very good! I would try: Animating colour changes

    Making the cursor a text cursor when hovering over text (did you change this intentionally?)

    Saving the theme/user in LocalStorage/Cookies

    Unfortunately, I did notice one major bug - when you click on the link to the website, unless the link contains http:// or https:// at the beginning, it will not link to the external website. You might want to write some code to check for this and make sure that all links are redirecting properly. Otherwise, good work!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord