Frontend Mentor | GitHub user search app using Flexbox and CSS Grid coding challenge solution

Solution retrospective

Originally I used prefers-color-scheme media queries to set the initial colour theme but with this method my javascript for the theme toggle button worked on Chrome but not Firefox so I ended up changing my approach to setting the initial colour theme.

I also struggled with what to do/where to place the error message on smaller screen sizes.

Any suggestions on how I can improve are welcome!

Community feedback

Billy Hick• 330

@TheArkhamKnight781526

Posted over 2 years ago

Overall, this is very good! I would try: Animating colour changes

Making the cursor a text cursor when hovering over text (did you change this intentionally?)

Saving the theme/user in LocalStorage/Cookies

Unfortunately, I did notice one major bug - when you click on the link to the website, unless the link contains http:// or https:// at the beginning, it will not link to the external website. You might want to write some code to check for this and make sure that all links are redirecting properly. Otherwise, good work!

Marked as helpful

Nakoya Wilson• 1,530

@nakoyawilson

Posted over 2 years ago

@TheArkhamKnight781526 Thanks for the feedback. Could you give me an example of a profile you searched for that illustrates the bug. I haven't come across any profiles with this issue when I've searched.

Billy Hick• 330

@TheArkhamKnight781526

Posted over 2 years ago

@nakoyawilson I used "bradtraversy" to check it

Nakoya Wilson• 1,530

@nakoyawilson

Posted over 2 years ago

@TheArkhamKnight781526 Thanks.

Billy Hick• 330

@TheArkhamKnight781526

Posted over 2 years ago

@nakoyawilson No problem!