GitHub User Search app using React and Tailwindcss

Community feedback

• 

  nicodes•240

  @nicodes-dev

  Posted almost 3 years ago

  Hi Daniel! You've done a great job on this challenge. Only thing I think that is missing is the opacity when the link is unavailable, overall it looks great.

  // In your App.tsx
   const [searchData, setSearchData] = useState<DefaultData>(defaultData)
  
      useEffect(() => {
          setSearchData(defaultData)
      }, [])
  

  You already set the default value of searchData to defaultData so I don't think the useEffect is still needed. But you can improve this by passing your fetch function to search for the default user inside useEffect.

  // In App.tsx
  
      useEffect(() => {
           const asyncFn = async = () => {
                await handleSubmit('octocat')
           }
  
      asyncFn()
     },[handleSubmit]
  

  But if you pass your handleSubmit function inside useEffect, you need to memoize it by wrapping it in a useCallback hook because it will cause an infinite loop inside the useEffect.

  // In useSearchSubmit hook 
  
       const handleSubmit = useCallback (async() => {
              // all your codes 
  } ,[])
  

  I haven't learn typescript yet but I hope this is still helpful.

  11