Skip to content
Submitted about 3 years ago

GitHub user search using React and MUI

react, material-ui
Matt Seidel•570
@mseidel819
A solution to the GitHub user search app challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

The links section at the bottom doesn't look great with long urls. Any suggestions on how to tighten that up?

When there is no user found, what should I display in the profile container?

Code

Please log in to post a comment

Log in

Community feedback

  • Vanza Setia•27,715
    @vanzasetia

    Hi, Matt Seidel! 👋

    Good effort on this challenge! 👍

    Regarding the long URL, I also experienced the same thing. I suggest reading my README where I explain the issue and how to solve the issue. But, to give your an overview of the answer, you can use some CSS properties to solve the issue (text-overflow, overflow, and white-space).

    If the user doesn't exist then I would recommend only showing the "No results" message without wiping out the content inside the container. I can't give you a guide on how to do it since I am not a React developer. 😅

    One small suggestion I have is to fix the issues that have been reported by Frontend Mentor. Also, one bug that I noticed in your app is that I have to click the search button to search the user. I can't just use the Enter key to search for a user. It might be because the input and the search button is not wrapped by the form element.

    That's it! I hope this helps! 🙂

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord