Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Github_User_Search

#sass/scss
Darya 160

@DHolets99

Desktop design screenshot for the GitHub user search app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi! Another challenge completed. I's my first work with API. Any feedback is welcome, as I'm still a beginner with it. Thanks!

Community feedback

Alex Li 400

@awexli

Posted

Awesome work! :-) I learned something new (window.matchMedia & prefers-color-scheme)

Some things I noticed:

  • Right now, users might find it frustrating to have to manually clear the search bar for every new search. What do you think about automatically clearing the search bar after making a request?
  • My operating system prefers dark-mode, but clicking on 'light' icon does not switch it to light-mode on the first try. Try using window.matchMedia('(prefers-color-scheme: light)').matches instead! This returns a boolean (true/false) if the user prefers light scheme

Marked as helpful

1

Darya 160

@DHolets99

Posted

@awexli

Thanks! It's very helpful comment. I have made changes to these points :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord