Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Grid and Plain css is used

KTβ€’ 390

@KtGitIt

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Greetings all,

Any feedback on anything is highly appreciated.

Is it correct that in grid layout, responsiveness of "auto-fit, minmax value" will not work because grid item is explicit place on different column?

Best regards, KT

Community feedback

P
ApplePieGiraffeβ€’ 30,545

@ApplePieGiraffe

Posted

Hello there, KT! πŸ‘‹

Nice work on this challenge! πŸ™Œ Yeah, you might have to be a little more explicit with CSS grid in this challenge since one card span two rowsβ€”I'm no CSS grid expert though, so there could be a way, maybe... πŸ§πŸ˜…

Besides that, I'd like to suggest,

  • Adding a little more margin/padding between the sides of the grid and the edges of the page (so that there's a little more room between the two when the width of the screen decreases).
  • Adding a max-width to the testimonial cards and centering them in the viewport in the mobile layout so that they aren't too wide when the layout first changes.

Keep coding (and happy coding, too)! 😁

1

KTβ€’ 390

@KtGitIt

Posted

Thank you for the feedback :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord