Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Grid

Sethโ€ข 310

@AbdoX9

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Radekโ€ข 490

@Radexman

Posted

Hi there, good job on that project! If you donโ€™t mind, I will provide you with some feedback. So I checked your code and it appears that you used <h2> tag before <h1>. This is considered a mistake because when using headings we want to stick to the so - called hierarchy. You probably did it because the font size was correct but you can just change it in css in no time. We typically want to start from h1 because it should be a main title on our page and move our way to h6. Here is some good resource on that topic:

https://www.contentkingapp.com/academy/headings/

Aside from that the code looks good, you have good naming convention for classes, there is indentation and some good whitespace going on. Very readable and self-explanatory.

Overall great work on that project! I hope I was a little bit helpful for you. Keep going and happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord