Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Grid Layout Design

Taher P 120

@CoolTaher

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


i want to perfect the sizeing ....... learned some grid content ; )

Community feedback

@zineb-Bou

Posted

Hi there, some suggestions that may help you to improve your solution

  • Your solution doesn't cover different screen sizes, make sure to keep it responsive.

  • Setting the container to an explicit width, won't allow it to scale down when changing between screens, also the reason why there is a horizontal overflow when changing to small screens, so always avoid setting explicit width or height, the height could be even worst because the container won't ever grow the fit the content inside it.

  • Avoid using ids to select your CSS elements, using a good naming convention (for instance BEM) you will be able to give your element unique class names.

  • You are repeating border-radius for imgQuote note that CSS will never consider the first value, will take the last one, make sure to never repeat the same property twice

0

Taher P 120

@CoolTaher

Posted

@zineb-Bou thanks for valueable suggestion i will definitely work on it ,just want to clear the blocks of confusion thankyou once again... <3

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord