grid layout landing page

Community feedback

• 

  Anna Leigh•5,135

  @brasspetals

  Posted over 4 years ago

  Hello again, Saman! Congrats on submitting another solution. 😄

  You did yet another good job on this challenge, but I do have a few suggestions:

  • On large screens (ex: 1920px), the header background image doesn’t fill the screen. Adding background-size: contain will fix this.

  • On the desktop version, there is too much space between the header and main. I suggest removing the height: 100vh from the header and using margins instead.

  • Increasing the font-size of your buttons. Here they are also technically not buttons, but “button” styled links, so I also suggest changing them to a tags to be more semantically correct.

  • Adding a max-width to your .maind-img since they get very large between 450px-800px.

  As always, happy coding!

  10
• 

  saman fayazi•170

  @saman-zdf

  Posted over 4 years ago

  Hello to you too brasspetals, thanks for taking your time and pointing out my mistakes, I'm really appreciate it, I'll fix them. is header should get margin from top you meant? Thanks.

  01