Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Grid page

Kadheryna 200

@kadheryna

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I'd like to receive feedback on my code :)

Community feedback

Kadheryna 200

@kadheryna

Posted

Thank you very much for your suggestions! :)

0
P

@MarkoNikolajevic

Posted

Hi Kadheryna, you did a good job with this challenge.

I just have a few suggestions about your code

  • looking at the report you can see that you have some issues that could be fix easily, as <title> tag that is empty or missing alt attribute in <img /> tag
  • I would suggest you to be more consistent in you sass code, for example if you started using px or rem keep on using one of these. Same for the colors, some of them are in hsl and other in rgba
  • the rgba is wrong because the last item is the alpha value and it goes from 0 to 1
h1,
    h2 {
      color: rgba(248, 252, 253, 255); // 255 should be from 0 to 1
    }
  • You could wrap some elements of cards in a <div> and I think it would be easier to work with them

  • I think there too many margin on mobile view into the cards

They are just a little fixes, overall your work is really good :)

Keep on coding

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord