Skip to content
Submitted over 1 year ago

Html-css

Jameela Ahmed•30
@Jameeelaahmed
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What did you find difficult while building the project? When I tried to center the container by display:flex , justify-content:center and align-items:center and it didn't respond untill i've added min-height:100vh to the container and body and i still don't know why because i've used display flex before without adding min-height

Code

Please log in to post a comment

Log in

Community feedback

  • hitmorecode•7,540
    @hitmorecode

    Nice well done. The reason why flexbox didn't work is, because when you first start with a page the height of the body is always 0. Even thou you see a full background when you open an empty page. The height of the body grows as you add content to it, by adding min-height: 100vh; you are defining the height of the body.

    In your case the height of the body was the same as the height of the card, that's why it seemed that flexbox was not working.

    With min-height: 100vh; and flexbox on the body, you will be able to place the card in the middle of the page. With that you can remove position, margin, transform that you used to place the card in the middle of the page.

    Marked as helpful
  • Basheer.Dev•40
    @Basheer007

    Align item Don't work until you set height because where do the align-items center that.

    Marked as helpful
  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.
    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
    • For example:
      • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
      • The <footer> typically contains information about the author of the section, copyright data or links to related documents.
    • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord