HTML 5 using CSS Flexbox

Community feedback

• 

  Bob•105

  @robakerson

  Posted almost 4 years ago

  Hey Carlos,

  I know this is a small thing but you are missing

  cursor:pointer;

  on your active states for the payment & cancel buttons

  12

  Marked as helpful
• 

  

  Grace•32,130

  @grace-snow

  Posted almost 4 years ago

  Well done on this, it looks good!

  A few suggestions

  • don't give alt descriptions to decorative images. If they are unimportant images, leave alt blank and add either aria-hidden true or role presentation.
  • change is an action so should probably be a button
  • proceed and cancel both imply navigation so should probably be anchor tags not buttons
  • remember you don't need to wrap everything in a div. That's just a block element, so if it only has one child element inside you can lose it and add display lock to the child if needed

  Good luck

  11

  Marked as helpful
• 

  Quibble7s•130

  @Quibble7s

  Posted almost 4 years ago

  Check out the BEM naming convention!

  11

  Marked as helpful
• 

  Manoj Kumar Singh•530

  @manojks092

  Posted almost 4 years ago

  Try to name the classes much relevant to the content of the element, this will help you remember what you are working on. You can think it as giving a title to a chapter.

  12

  Marked as helpful