Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

HTML and CSS

sass/scss
SOKOUDJOU Leopold•40
@SOKOUDJOU-LEOPOLD
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are the best practices

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • mubizzy•1,520
    @mubizzy
    Posted almost 3 years ago

    Excellent job on this challenge! your report has a few issues though:

    1. wrap everything in your body in <main> or use semantics

    2.   it is a best practice to use both HTML 5 and ARIA landmarks to ensure all     content is contained within a navigational region.

    Hope it helps:)...don't forget to mark it as helpful 👍

    You can get more details here...click here

  • Angélique D. Faye•390
    @AngeliqueDF
    Posted almost 3 years ago

    Hi @SOKOUDJOU-LEOPOLD!

    You should change the name of your qr-code.html to index.html then push changes to the repository. The project's GitHub page should then be online and functioning. Or at least, you will see any bug on the live version.

    As for your code, start with:

    • Use semantic HTML elements. This will improve accessiblity and SEO.
    • Reduce CSS selectors specificity. In such a small app it might not be such a problem, but it's good to get into the habit of using more specific selectors only when necessary.
    • Use more adapted CSS rules for the job.

    Some resources to help you:

    • https://developer.mozilla.org/en-US/docs/Web/HTML, here you can find a list of HTML elements available to you to structure the HTML.
    • https://developer.mozilla.org/en-US/docs/Web/CSS, to find more adapted CSS rules to achieve the layout you're trying to reproduce.

    Some tools to help you: If you don't know where to start, you can use tools such as Lighthouse to scan the page (the live version or the one on localhost, use the Google chrome extension) and get tips on what to improve.

    Hope this helps!

  • Asmaa Elfatayry•870
    @asmaa-elfatayry
    Posted almost 3 years ago

    hello SOKOUDJOU, You have some problems:

    first, you should use the same colors and style you will find this in the folders you download that named style. guide

    second in the src of the img you must write ../ before the path image-qr-code.png to correct it hope this link help you https://www.w3schools.com/Html/html_filepaths.asp

    third you should make a live site in GitHub and not take screen you can watch this video https://www.youtube.com/watch?v=o5g-lUuFgpg

    and finally to solve ACCESSIBILITY ISSUES you should put all the code of the body inside <main></main> tag

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub