HTML and CSS and JS website

Community feedback

• 

  Tyson W•305

  @Tyson-Wellings

  Posted almost 4 years ago

  You are getting an error in your report related to landmarks. I too had the same issues with my projects. What I learned is that you must divide the body section into

  body header/header main/main footer/footer /body

  Since doing so I no longer receive this error.

  https://www.w3.org/TR/wai-aria-practices/examples/landmarks/HTML5.html

  I'm quite early on in my CSS development so I do not feel qualified to give feedback on that portion however I would like to say I found your use of REM units for text interesting. I personally would also like to utilize these units more so I would love to hear your reasoning behind their use.

  03

  Marked as helpful
• 

  Grzegorz Sterczewski•680

  @gsterczewski

  Posted almost 4 years ago

  Hello Anwar 👋, my name is Grzegorz.

  Reagrding the css and accessibillity I have a few observations:

  • You could add focus state on clickable elements, so when I navigate it with keyboard I can see the same effect as with hover with mouse.

  • Headings are not in sequential order (you've skipped h2) and you have multiple h1 (there should be only one per page). Use h2 h3 etc. and style them in CSS if you need them to be bigger/smaller.

  • Consider adding the same hover state on social media links as in other links in the footer section for consistency.

  • Links in nav could also use some visual tips when you hover or focus on them.

  Your are on the right path, continue to improve your solution and you will get it perfect soon.

  Keep up the good work! 💪

  See you on the coding trail 😉

  Cheers!

  01

  Marked as helpful