HTML and CSS and some media query. one inner style.

Community feedback

• 

  IRVINE MESA•1,835

  @DrMESAZIM

  Posted about 3 years ago

  Hi @semi26

  I noticed that there is need to remove some text decoration on the following classes

  btn btn-change btn btn-change

  To do that simply add this property on line 6 inside the file style.css

  text-decoration:none

  11

  Marked as helpful
• 

  Vanza Setia•27,715

  @vanzasetia

  Posted about 3 years ago

  Hello there, Raul! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 Your solution looks pretty good! Also, well done on leaving the alt empty to all decorative images! 👏

  There are still some things that can be improved.

  • I highly suggest never using inline styling. It's not reusable and hard to maintain. Also, it has very high specificity. So, my recommendation is always to put all the styling into the external CSS.
  • Always specify the type of the button. In this case, set the type of them as type="button". It's going to prevent the button from behaving unexpectedly.
  • On mobile view (375px width) I recommend adding some padding on body to prevent the card from touching the browser's edges.
  • Create a custom :focus-visible styling to any interactive elements (button, links, input, textarea). This will make the users that navigate this website using keyboard (by using Tab key) know where they are on the page.

  I hope this helps! Keep up the good work! 👍

  15

  Marked as helpful
• 

  Kamasah-Dickson•5,570

  @Kamasah-Dickson

  Posted about 3 years ago

  Your card is covering the whole screen on smaller devices, give a margin left and right on smaller devices to avoid your card from spanning the whole screen.

  • there is also so much box shadow on the button.
  • you also forgot to add a box shadow to your card.

  Besides good job👍 Keep coming👍

  13

  Marked as helpful