Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

Html & Css - Flexbox

bem
Amir Hashemi•480
@AmirhosseinHashemi
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I hope you review my code and help me to fix my problem and write cleaner code.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Zienab Mohammed Abdelmonaem•400
    @zenab12
    Posted about 3 years ago

    Hey!! Congratulations for completing this challenge.. .

    Here are my suggestions..

    1-use <main> tag and wrap <div class="card"></div> inside it to make code semantic

    2-Go down orderly when you are using the headings h1 down to h2 down to h3 and so on . so use h1 instead h3 and change font-size if you want .. This should fix most of your accessibility issues

    Regardless you did amazing ,I checked your code on w3 validator and there is no errors or warning in your code and you wrote clean and responsive code using semantic name classes (this make code readable) and flexbox(responsive) so congratulations... hope you find this useful... Happy coding and nice day :-)!!!

    Marked as helpful
  • Praise Immanuel•250
    @PraiseImmanuel
    Posted about 3 years ago

    You did a nice work pal. You just had a few accessibility issues. I will advise you always add a (lang = "en-us") attribute to your HTML tag. I believe this link will help

    www.w3schools.com/html/html_accessibility.asp

    Marked as helpful
  • CyrusKabir•1,885
    @CyrusKabir
    Posted about 3 years ago

    Hello my dear friend ♥ you did good on this challenge and here some improvements for your component :

    • adding some transitions to your hover effects can make them smooth and better.
    • as you can see in hover state on your card img, your overlay opacity: 0.5 add some opacity to eye icon (svg) so in this design we can see the eye icon have not any opacity so here it's because of little difference between opacity and rgba or any color system with an alpha for opacity, and and you can read about this problem on this stackoverflow post difference between opacity and alpha.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub