Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML and CSS ( Flexbox) 3 column preview card component

Luka 180

@Luka85

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
Grace 27,710

@grace-snow

Posted

Hi Luka

This looks fantastic! Just a few improvements needed on the html

Those buttons should be anchor tags as they would trigger navigation, not an action

It's up to you if you think those icons are meaningful, in which case you should include a value in the alt attributes. If you think they are not meaningful/important content, leave the alt empty like alt="". Or if you think they are valuable content, the alt text needs to be written slightly differently to what you have now. You don't usually say words like image or picture because they are announced as images anyway, but the word icon -could be helpful. If words are initials or abbreviations like SUV they need to be capitalised for screen readers to read them correctly.

Really nice looking solution. I hope this extra info is helpful for you in this or other challenges

1

Luka 180

@Luka85

Posted

@grace-snow I fixed the issues, so changed the button to anchor tags and change the alt attributes to alt="" cause they are not meaningful. What do you think now?

Thank you for your feedback,

Luka

0
Luka 180

@Luka85

Posted

Hi Grace.

Thank you so much for your feedback, it helped me a lot, cause I am still "new" in this field. I was more concerned about my CSS then HTML, but everyday you learn something new.

Thanks again and have a great one.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord