Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML and CSS for QR Code Payment

#contentful#cube-css#webflow#wordpress#accessibility

@marisamie

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi I'm beginning for front-end developer this is my QR Code Payment create by use HTML and CSS if you have any suggestion pls feel free to comment me I want to practice more an more :)

Community feedback

hitmorecode 6,270

@hitmorecode

Posted

Nice congratulations looks good. I only have one comment. You used <br> to break the paragraph. You don't have to do this. If you give the <p> a width a new line will be automatically created.

Anyways good job keep it up

Marked as helpful

1

@Mennatallah-Hisham

Posted

Hi marisa,

Congratulations on completing your first challenge👏

You did great 👍

Here are some suggestions to improve your code:

Semantic HTML

  • wrap your content in <main>,this element represents the dominant content of the <body>
  • wrap your card in <article>
<main>
<article>
</article>
<div>
</div>
</main>

SEO

  • you can add meta description for better SEO, it provides a brief summary of a web page
<meta name="description" content="..........."/>  

here are some helpful articles:

1
_nehal💎 6,710

@NehalSahu8055

Posted

Hello Coder 👋

Congratulations on successfully completing the challenge! 🎉

Few suggestions regarding design.

  • For non-decorative images give meaningful and descriptive alt like alt= "QR code to frontend mentor website".

  • Use Semantics for the proper design of your code.

<body>
<main>... main content goes here ...</main>
<footer>... .attribution div goes here ... </footer>
</body>
  • Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

I hope you find this helpful.

Happy coding😄

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord