Skip to content
Submitted over 1 year ago

HTML and CSS for QR Code Payment

contentful, cube-css, webflow, wordpress, accessibility
Marisa Phungbunphra•20
@chalisamie
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Hi I'm beginning for front-end developer this is my QR Code Payment create by use HTML and CSS if you have any suggestion pls feel free to comment me I want to practice more an more :)

Code

Please log in to post a comment

Log in with GitHub

Community feedback

  • hitmorecode•7,240
    @hitmorecode

    Nice congratulations looks good. I only have one comment. You used <br> to break the paragraph. You don't have to do this. If you give the <p> a width a new line will be automatically created.

    Anyways good job keep it up

    Marked as helpful
  • Mennatallah Hesham•1,470
    @Mennatallah-Hisham

    Hi marisa,

    Congratulations on completing your first challenge👏

    You did great 👍

    Here are some suggestions to improve your code:

    Semantic HTML

    • wrap your content in <main>,this element represents the dominant content of the <body>
    • wrap your card in <article>
    <main>
<article>
</article>
<div>
</div>
</main>

    SEO

    • you can add meta description for better SEO, it provides a brief summary of a web page
    <meta name="description" content="..........."/>

    here are some helpful articles:

  • _nehal💎•6,710
    @NehalSahu8055

    Hello Coder 👋

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    • For non-decorative images give meaningful and descriptive alt like alt= "QR code to frontend mentor website".

    • Use Semantics for the proper design of your code.

    <body>
<main>... main content goes here ...</main>
<footer>... .attribution div goes here ... </footer>
</body>
    • Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

    I hope you find this helpful.

    Happy coding😄

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord