Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

HTMl & CSS

accessibility, airtable, material-ui, astro
Abdessamad•210
@styrexx
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi! The is my first contribute of my Solution and feel free to put your feedback

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Francisco Carrillo•5,540
    @frank-itachi
    Posted over 2 years ago

    Hello there 👋. You did a good job!

    I have some suggestions about your code that might interest you.

    HTML 📄:

    • Wrap the page's whole main content in the <main> tag.
    • The heading order is important in the html structure so try to always start your headings with an <h1> tag and then you can decrease by one if you need to use more heading in your html code.

    CSS 🎨:

    You can use grid or flexbox to center the content no matter the viewport size. Since I use grid to achieve such purpose, you can do the following:

    body {
    	min-height: 100vh;
            display: grid;
    	align-items: center;
    	justify-content: center;
    }
    

    As I said, you can use flexbox to center the content and it will work as well.

    body {
    	min-height: 100vh;
            display: flex;
    	align-items: center;
    	justify-content: center;
    }
    

    I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!

    Happy <coding /> 😎!

    Marked as helpful
  • Vanza Setia•27,715
    @vanzasetia
    Posted over 2 years ago

    Hi, C-Shadow! 👋

    Congratulations on completing your first Frontend Mentor challenge! 🎉

    There are a few changes you can do to make your solution better.

    • Alternative text for the QR code should describe the purpose of the QR code.
    • Wrap "Improve Your Front-End Skills By Building Projects" with a <h1> instead of <p> element. Each page should have at one <h1>.
    • Fix the issues that have been reported.
    • Use flexbox or grid to place the card in the center of the page. These modern techniques are more robust than absolute positioning and have less code to write.
    • Use a CSS reset whenever you start a new project. This can help you set the styling foundation easily. My recommendation — A Modern CSS Reset | Andy Bell
    • Never limit the height of the <body>. It will not allow the users to scroll the page when the page content needs more height. Try to look at the site on a mobile landscape view to see the issue. So, use min-height instead.
    • Remove the media query. You should only set a max-width to the card. Make the <img> element as a block element and set max-width: 100% to prevent it from overflowing.

    I hope you find this useful. Happy coding! 😄

    Marked as helpful
  • Pedro Virgilio•30
    @Pvvirg
    Posted over 2 years ago

    It was very cool

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub