HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted over 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  iMAGES 📸:

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.

  ---

  • The alt attribute should explain the purpose of the image.

  ---

  • E.g. alt="QR code to frontendmentor.io"

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  01

  Marked as helpful
• 

  Brian Michael Poblete•490

  @Brian-Pob

  Posted over 2 years ago

  Hello there 🙋‍♂️! Great job on this challenge 🎉!

  I think it's awesome that you're asking questions about how to learn more efficiently. Wanting to learn how to learn better is already a great mindset to have.

  When learning a new concept, I like to watch a video tutorial explaining the concepts. I then write down any questions that I have and see if a rewatch helps me answer those questions. Otherwise, I then try to read any official documentation on the topic if it exists.

  Looking at the HTML and Accessibility reports that Frontend Mentor gives is a good starting point if you want to improve your knowledge and skills.

  I have a few links below that will help you resolve those errors.

  Accessibility ♿️:

  • Document should have one main landmark. Landmarks help accessibility tools navigate your page.
  • Alt text. Alt text in images allow tools like screen readers to properly convey the content of your site.
  • Level 1 heading. For accessibility reasons, pages should always have an <h1> tag.

  HTML Validation Report 🔨:

  • Add some alt-text to the <img> tag describing what the image is or what it is for.
  • You may have wanted to use an <h1> tag instead of just <h>.

  I hope this helps! ✌️

  I look forward to seeing more of your work in the future! 😄

  01

  Marked as helpful